Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

fix: today stats overflow

Open MorenoTropical opened this issue 1 year ago • 2 comments

Fixes

  • Fixes #14641

Approach

I made it multi-line

How Has This Been Tested?

Increased the device font size and took a screenshot

overflow

Checklist

Please, go through these checks before submitting the PR.

  • [X] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [X] You have commented your code, particularly in hard-to-understand areas
  • [X] You have performed a self-review of your own code
  • [X] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [X] UI Changes: You have tested your change using the Google Accessibility Scanner

MorenoTropical avatar Aug 26 '24 22:08 MorenoTropical

A fix for that issue should use WindowInsets to handle phones with rounded corners and the bottom drag bar disabled.

lukstbit avatar Aug 27 '24 06:08 lukstbit

A fix for that issue should use WindowInsets to handle phones with rounded corners and the bottom drag bar disabled.

I tried and looked at WindowInsets, but the problem happens despite of the screen having rounded corners or not, like when the device font size is set to big

MorenoTropical avatar Aug 27 '24 20:08 MorenoTropical

I don't think this is the proper fix, making it multi line might work when the text is bigger but it isn't going to work if the text barely fits in one line and gets near the edges and the screen. I still think WindowInsets should be used especially as edge to edge will become the default with Android 15.

lukstbit avatar Sep 08 '24 07:09 lukstbit

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Sep 22 '24 07:09 github-actions[bot]

@lukstbit the link is dead. Medium suspended the account. Any other link you'd get please?

Arthur-Milchior avatar Nov 03 '24 12:11 Arthur-Milchior

@Arthur-Milchior https://developer.android.com/about/versions/15/behavior-changes-15#ux

lukstbit avatar Nov 04 '24 12:11 lukstbit