Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

[GSoC'24] Analytical widget provider class for Deck Picker Widget .

Open xenonnn4w opened this issue 1 year ago • 4 comments

Purpose / Description

Adding Up Analytical widget provider class for Deck Picker Widget .

How Has This Been Tested?

[GSoC'24] Implementation of Deck Picker Widget . #16450

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

xenonnn4w avatar Jun 04 '24 14:06 xenonnn4w

You should use this with our current classes

david-allison avatar Jun 04 '24 14:06 david-allison

You should use this with our current classes

Sorry, didn't understand what you meant by that

xenonnn4w avatar Jun 04 '24 17:06 xenonnn4w

Screenshot 2024-06-04 at 19 08 30

Two widget classes appear to be using this functionality and have duplicated code. You're planning on adding a third which also uses this functionality, so the concern was extracted to a class

You should add the class which you've created into the inheritance hierarchy for the two other classes to reduce complexity

david-allison avatar Jun 04 '24 18:06 david-allison

I don't understand you "how has this been tested" section. Can you please explain how the link refers to tests ?

Arthur-Milchior avatar Jun 10 '24 23:06 Arthur-Milchior

Pinged Arthur for re-review

david-allison avatar Jul 08 '24 09:07 david-allison

Still has conflicts

  • please squash merge

david-allison avatar Jul 18 '24 18:07 david-allison

@Arthur-Milchior

david-allison avatar Jul 18 '24 19:07 david-allison

Why is this no longer applied to AnkiDroidWidgetSmall?

for some reason widget_eta and widget_due are not rendering after these changes , was investigating that onl;y

xenonnn4w avatar Jul 21 '24 20:07 xenonnn4w

You should be communicating that this is the case

david-allison avatar Jul 21 '24 20:07 david-allison

Hi there @xenonnn4w! This is the OpenCollective Notice for PRs merged from 2024-07-01 through 2024-07-31

If you are interested in compensation for this work, the process with details is here:

https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid

[!IMPORTANT] PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.

We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month

Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.

Thanks!

github-actions[bot] avatar Sep 15 '24 22:09 github-actions[bot]