ankidroid
Make permission item fully touchable
Purpose / Description
In PermissionActivity, the permission item is not fully touchable, unlike in the settings.
Approach
setOnClickListener on root layout.
How Has This Been Tested?
https://github.com/ankidroid/Anki-Android/assets/119813120/b256bfce-0b05-4121-9ab6-d705c24b5514
Checklist
Please, go through these checks before submitting the PR.
- [x] You have a descriptive commit message with a short title (first line, max 50 chars).
- [ ] You have commented your code, particularly in hard-to-understand areas
- [x] You have performed a self-review of your own code
- [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
- [ ] UI Changes: You have tested your change using the Google Accessibility Scanner
If you are setting the onClick listener to the root layout, then it would be best to remove the redundant code from the switch listener ? I might be wrong but if the layouts can be merged then it can only be set to the parent layout
Can you add a video? Also, did you test if the switch is unchecked when declined?
@criticalAY I don't understand will you please explain what actually i have to do.
Tap the switch, nothing happens. It will work only if you tap the layout i.e. the switch/layout should both be tappable and lead to same action
Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Repeating myself:
If the whole element is going to be a touch area, it needs some kind of visual feedback, like a Setting does.
Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically
it needs some kind of visual feedback, like a Setting does
@BrayanDSO What do you mean by visual feedback? I don't understand. Will you please explain again?
When you press a setting, there's a gray animation that flows like a wave that acts as feedback. So, something like that.
Hi there @gayatriii0803! This is the OpenCollective Notice for PRs merged from 2024-10-01 through 2024-10-31
If you are interested in compensation for this work, the process with details is here:
https://github.com/ankidroid/Anki-Android/wiki/OpenCollective-Payment-Process#how-to-get-paid
[!IMPORTANT] PLEASE NOTE: The process was updated in August 2024. Re-read the Payment Process page if you have not already.
We only post one comment per person per month to avoid spamming you, regardless of the number of PRs merged, but this note applies to all PRs merged for this month
Please understand that our monthly budget is never guaranteed to cover all claims - the cap on payments-per-person may be lower, but we try to make our process as fair and transparent as possible, we just need your understanding.
Thanks!