Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard
verified publisher icon ankidroid

use sentence casing

Open gayatriii0803 opened this issue 1 year ago • 7 comments

Purpose / Description

sentence casing

Fixes

  • Fixes #16120

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [ ] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

gayatriii0803 avatar May 30 '24 08:05 gayatriii0803

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

github-actions[bot] avatar May 30 '24 08:05 github-actions[bot]

This is not how this issue should be fixed. In the linked issues there's a comment with more information https://github.com/ankidroid/Anki-Android/issues/16120#issuecomment-2041213568

lukstbit avatar May 31 '24 11:05 lukstbit

@lukstbit Will you please guide me how to do this? Because the string is directly used in xml layout so that's why I can't call toSentenceCase()

gayatriii0803 avatar Jun 03 '24 08:06 gayatriii0803

If you look inside ControlSettingsFragment you can see a method where one of the preferences is set dynamically. Use it as an example.

lukstbit avatar Jun 03 '24 16:06 lukstbit

@lukstbit I don't find any method. Will you please share code snippet?

gayatriii0803 avatar Jun 07 '24 06:06 gayatriii0803

https://github.com/ankidroid/Anki-Android/blob/94de856406ea3627302c82c28a7c261a824fcae4/AnkiDroid/src/main/java/com/ichi2/anki/preferences/ControlsSettingsFragment.kt#L45-L49

lukstbit avatar Jun 12 '24 05:06 lukstbit

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Jun 26 '24 05:06 github-actions[bot]