Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Use sentence casing in some settings

Open brishtibheja opened this issue 1 year ago • 11 comments

If you go to Settings>>Controls then a few inconsistencies appear in capitalisation. The ones that I could spot are:

  1. F in Flag is capitalised when it should be not.
  2. W in Toggle Whiteboard is capitalised but other instances of whiteboard in the same screen are not.
  3. L is not capitalised in Abort learning when it is in Abort Learning and Sync.

brishtibheja avatar Apr 06 '24 19:04 brishtibheja

Good first issue, I won't take it on

For implementers: look to the PRs introducing

https://github.com/ankidroid/Anki-Android/blob/97b299ef3737c36c044147d849ab0171e9371307/AnkiDroid/src/test/java/com/ichi2/anki/ui/internationalization/SentenceCaseTest.kt

  • https://github.com/ankidroid/Anki-Android/pull/15781
  • https://github.com/ankidroid/Anki-Android/pull/15760

david-allison avatar Apr 06 '24 21:04 david-allison

Please Assign me @david-allison

Aditya13s avatar Apr 07 '24 09:04 Aditya13s

This is currently the 4th issue assigned to you @Aditya13s. Try to finish one of other ones that you are assigned to before asking to do more stuff.

BrayanDSO avatar Apr 07 '24 16:04 BrayanDSO

Hi! Is this issue still availble? Thanks!

MartiPresa avatar Apr 09 '24 18:04 MartiPresa

It is, thanks!

david-allison avatar Apr 09 '24 18:04 david-allison

hey is anyone working on it? or please assign me this issue.

jainishrpandya avatar Apr 10 '24 11:04 jainishrpandya

Hey Akshaykomar890 just a heads up - I submitted the pull request for the issue #16160, but forgot to assign it to myself. I'll take care of that now. Let me know if you have any feedback or need anything else."

Akshaykomar890 avatar Apr 12 '24 02:04 Akshaykomar890

Hi @MartiPresa

I hope you're doing well. I wanted to check in regarding the #16120 that you're assigned to. Could you please provide an update on the progress of this issue?

Your response will help us determine the next steps regarding the related PR.

Thanks,

Akshaykomar890 avatar Apr 13 '24 05:04 Akshaykomar890

Is there anyone working on it? if not I would like to work on it.

gayatriii0803 avatar May 30 '24 05:05 gayatriii0803

Assigned, thanks

david-allison avatar May 30 '24 08:05 david-allison

Finally this closes 😅

brishtibheja avatar May 30 '24 10:05 brishtibheja

Hey ,can i work on this issue if no one is working on it

jainv4156 avatar Jul 18 '24 07:07 jainv4156

Sure

david-allison avatar Jul 18 '24 20:07 david-allison

hey @david-allison i think i got the solution but i have a question . There is no function for desired string in Generated Translaion file That i can use with "TR" can i directly use String Resourse xml in place of translation

jainv4156 avatar Jul 19 '24 04:07 jainv4156

https://github.com/ankidroid/Anki-Android/blob/94de856406ea3627302c82c28a7c261a824fcae4/AnkiDroid/src/main/java/com/ichi2/anki/preferences/ControlsSettingsFragment.kt#L45-L49

jainv4156 avatar Jul 19 '24 04:07 jainv4156

@jainv4156 sorry, I don't understand what you're asking. Can you post a patch here with your proposal

david-allison avatar Jul 19 '24 07:07 david-allison

i have made the changes should i directly raise a pr

jainv4156 avatar Jul 19 '24 07:07 jainv4156

Push the branch and link it for now. I don't understand what you proposed

david-allison avatar Jul 19 '24 07:07 david-allison

ok ,sure

jainv4156 avatar Jul 19 '24 07:07 jainv4156