Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

[Enhancement] Crop tool for image occlusion

Open Devaprasad-reddy opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe. I want to crop out giveaways in an IO card but to do it I had to delete the card and crop it in my phone and upload as a new card, which also makes me loose the progress of that card

Describe the solution you'd like A crop tool in the IO editing interface would be nice to have

Describe alternatives you've considered Creating a New card again.

Additional context Also two finger pan would be nice instead of 4 buttons to zoom in and out.

Devaprasad-reddy avatar Mar 12 '24 06:03 Devaprasad-reddy

I would like to work on this @david-allison

awanishyadav967 avatar Mar 12 '24 11:03 awanishyadav967

Thanks! See the following for how we currently open a crop tool:

https://github.com/ankidroid/Anki-Android/blob/a2c16051a4891292e6c571d5f1fac7910311997b/AnkiDroid/src/main/java/com/ichi2/anki/multimediacard/fields/BasicImageFieldController.kt#L98

david-allison avatar Mar 12 '24 12:03 david-allison

Just in case #15029 get merged before this then we just need to call the method

criticalAY avatar Mar 12 '24 12:03 criticalAY

Hi @david-allison I created the new PR ,Please Review it.

awanishyadav967 avatar Mar 22 '24 06:03 awanishyadav967

@awanishyadav967 In future, no need to ping me on GitHub, I already get notifications for new Pull Requests, and Discord can be used for 'you should look at this' pings if it's not reviewed in a sufficient amount of time

david-allison avatar Mar 24 '24 01:03 david-allison

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] avatar Jun 22 '24 02:06 github-actions[bot]

Is this out..?

Devaprasad-reddy avatar Jun 22 '24 04:06 Devaprasad-reddy

Hello 👋, this issue has been opened for more than 3 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like still searching for solutions and if you found one, please open a pull request! You have 7 days until this gets closed automatically

github-actions[bot] avatar Nov 02 '24 02:11 github-actions[bot]