Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard
verified publisher icon ankidroid

fix: flaky NoteEditorIntentTest

Open criticalAY opened this issue 1 year ago • 7 comments

Purpose / Description

Flaky test if trying to access edit field before it has loaded

Fixes

  • Fixes #15707

Approach

Place a check

How Has This Been Tested?

Locally tested on PC need CI testing passing though

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

criticalAY avatar Feb 28 '24 18:02 criticalAY

I have drafted the PR, if the CI passes and the changes are ok we can proceed otherwise would need more investigation

criticalAY avatar Feb 28 '24 18:02 criticalAY

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Mar 16 '24 19:03 github-actions[bot]

@criticalAY is this on us to re-review?

david-allison avatar Mar 18 '24 15:03 david-allison

Yes, I did comment after Mike replied so I was waiting for a response to act

criticalAY avatar Mar 18 '24 15:03 criticalAY

I will push one more change to test ci then rebase

criticalAY avatar Mar 19 '24 17:03 criticalAY

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Apr 30 '24 18:04 github-actions[bot]

keep open please

criticalAY avatar May 01 '24 20:05 criticalAY

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar May 15 '24 20:05 github-actions[bot]

Closing this to keep the PR queue clean - work is required here

david-allison avatar Jun 18 '24 10:06 david-allison