Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

var cleanup

Open Aditya8840 opened this issue 3 years ago • 2 comments

changed var to val

Purpose / Description Removed var from CardHtml.kt with issue https://github.com/ankidroid/Anki-Android/issues/11450.

Aditya8840 avatar Sep 08 '22 17:09 Aditya8840

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

welcome[bot] avatar Sep 08 '22 17:09 welcome[bot]

I fear @Aditya8840 you did not understand the goal here. The goal was to remove them when possible without changing the behavior of the code. Those value can indeed be moved to val, there is even multiple ways to do it. But this one is not proper

I'm fine taking some time helping you improve this PR, if you want so. The first point, as with most PR, is that you need to understand what the code does. Is it the case? Can you, if so, explain what you understand those two lines to do. This way, it'll help diagnose why the rewritting went wrong.

Arthur-Milchior avatar Sep 08 '22 22:09 Arthur-Milchior

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Nov 18 '22 10:11 github-actions[bot]