[GSoC] Rust Cleanup: remove unused cancelListener parameter
Would help in migrating CollectionTask.LoadDeckCount to Coroutines
Checklist
Please, go through these checks before submitting the PR.
- [x] You have a descriptive commit message with a short title (first line, max 50 chars).
- [ ] You have commented your code, particularly in hard-to-understand areas
- [x] You have performed a self-review of your own code
- [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
- [ ] UI Changes: You have tested your change using the Google Accessibility Scanner
cancelListener is unused in the v3 scheduler path, but the v2 scheduler does use it, so this PR would mean that the deck list generation can no longer be cancelled when v2 is active. @Arthur-Milchior may have an opinion here
(an argument could be made for allowing this regression based on the fact that a switch to the Rust backend is hopefully not too far off, and the fact that it will unblock the coroutine migration, but that's not my call to make. Once the Rust backend becomes the default, the v2 path could also use the backend to calculate the due counts)
Going through the cancellation issue, I found out that the cancellation functionality is only used here. I don't think it is used by the scheduler internally but rather the CollectionTask API, if I remove from v2 it would still be able to cancel the task from the onPause() callback.
If I got something wrong please let me know exactly where it is used.
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically
Based on the discussion, this change is better to be done after the new schema becomes the default. So closing it.