Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

[ViewBinding] Analytics Package

Open Jatin887 opened this issue 3 years ago • 5 comments

Pull Request template

Purpose / Description

Added ViewBinding for AnkidroidCrashReportDialog

Fixes

Part of (https://github.com/ankidroid/Anki-Android/issues/11116)

Approach

Removed findViewById with the help of implementing binding class for feedback.xml

How Has This Been Tested?

Physical Device OnePlus Nord2

Checklist

Please, go through these checks before submitting the PR.

  • [x] You have not changed whitespace unnecessarily (it makes diffs hard to read)
  • [x] You have a descriptive commit message with a short title (first line, max 50 chars).
  • [x] Your code follows the style of the project (e.g. never omit braces in if statements)
  • [x] You have commented your code, particularly in hard-to-understand areas
  • [x] You have performed a self-review of your own code
  • [ ] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

Jatin887 avatar May 09 '22 21:05 Jatin887

@david-allison Please review and let me know if the commit-message format is correct and whether I should continue with this and submit pull requests for all remaining packages. Are any adjustments required?

Jatin887 avatar May 09 '22 21:05 Jatin887

Please just keep to one commit, no need for little tack-on commits - you can locally squash + force-push

image

mikehardy avatar May 10 '22 17:05 mikehardy

Please just keep to one commit, no need for little tack-on commits - you can locally squash + force-push

image

yes i was just going to do that. I was waiting if thier are any other changes requried or not

Jatin887 avatar May 10 '22 17:05 Jatin887

Ah, that makes sense. And depending on what the follow-on work is doing, I can see having separate commits (until everything is resolved) actually aiding the reviewer. It's a matter of taste then, your workflow works for me - usually it's because people are new to git and simply don't squash / rebase at all, so I try to nudge them there ;-)

mikehardy avatar May 10 '22 18:05 mikehardy

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Aug 07 '22 23:08 github-actions[bot]

I'm going to draft this, as the PR got conflicts and the author hasn't been on github for months, to simplify the reviews' queue

BrayanDSO avatar Oct 30 '22 17:10 BrayanDSO

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Dec 29 '22 17:12 github-actions[bot]