node-rate-limiter-flexible icon indicating copy to clipboard operation
node-rate-limiter-flexible copied to clipboard

Future major v8 notes

Open animir opened this issue 4 years ago • 1 comments

  1. blockDuration option should be undefined by default, so 0 can be used to block keys forever.
  2. Make sure RateLimiterQueue is created with default maxQueueSize even if it isn't set in options object, e.g. new RateLimiterQueue(memoryLimiter, {}) shouldn't result to maxQueueSize set to undefined.
  3. Support for points set to 0 and never limit in this case. It is useful for atomic counters.

animir avatar Oct 30 '21 05:10 animir

consider adjusting the cb of the different implementations to return asynchronously if tableCreated: true - its not consistent w/ the other times cb is called.

another better design would be to have private constructors and a factory method that returns a promise

daniel-white avatar May 26 '23 13:05 daniel-white