nextplayer icon indicating copy to clipboard operation
nextplayer copied to clipboard
verified publisher icon anilbeesetti

Feat: Add video loop options

Open Yashraj254 opened this issue 2 years ago • 12 comments

Fix #572 added a functionality to play videos in loop

https://github.com/anilbeesetti/nextplayer/assets/52420957/96b33ad0-b1a8-49ab-b958-244e09a1e816

Yashraj254 avatar Oct 02 '23 10:10 Yashraj254

Minor thing, but in my opinion it would've looked a lot better if the icon wasn't fill color, in the video it outstands from the others...

drogga avatar Oct 03 '23 13:10 drogga

yeah i was thinking the same but the problem was there was no separate icon availble in vector assets for LoopOff button, so i just changed the color, now i have replace that icon with a different one... tell me how it looks now

https://github.com/anilbeesetti/nextplayer/assets/52420957/827ae835-061f-4952-956b-29b97f73e5cf

Yashraj254 avatar Oct 03 '23 17:10 Yashraj254

Good job. It looks better now.

drogga avatar Oct 03 '23 20:10 drogga

Hey @Yashraj254, What i'm thinking will be good is loop options like "loop one video", "loop all videos", "loop off".

anilbeesetti avatar Oct 09 '23 03:10 anilbeesetti

@anilbeesetti alright.. working on it

Yashraj254 avatar Oct 09 '23 08:10 Yashraj254

hey @anilbeesetti conflicts resolved. Ready for merge. Any further changes or feedback?

Yashraj254 avatar Jan 08 '24 10:01 Yashraj254

@anilbeesetti Are you still around ?

drogga avatar Jan 25 '24 02:01 drogga

Hey @drogga, I'm here. Thanks for checking in. I've been caught up with my new job and other stuff for the last two months. I'll be more engaged starting next month.

anilbeesetti avatar Jan 25 '24 02:01 anilbeesetti

Can we please get this merged? this basic feature is all that is stopping myself and i am sure many others from using this player right now.

Ausk8815 avatar May 03 '24 15:05 Ausk8815

mpv-android and just (video) player has this feature.

sewnie avatar Jul 14 '24 23:07 sewnie

Is there an issue with merging this request? I would really like to switch to this player. I am considering just forking it and manually copying the pull request and compiling an apk at this point.

If there is an actual merge issue maybe i can help?

Ausk8815 avatar Sep 14 '24 06:09 Ausk8815

Is there an issue with merging this request? I would really like to switch to this player. I am considering just forking it and manually copying the pull request and compiling an apk at this point.

If there is an actual merge issue maybe i can help?

Hey, I will try to merge this for the upcoming release

anilbeesetti avatar Sep 14 '24 06:09 anilbeesetti