Anh

Results 105 comments of Anh

I spent some time testing the https://fossa.com mentioned by @RSMNYS. I think the HTML version of the report looks quite good and we can include it either in the app...

Do we need a website? Currently, the app can upload, download and display the results from the same account stored as JSON files in Firebase. We can modify it to...

@RSMNYS Please find a way to not expose the API key (e.g. like reading the values from the environment variables like [here](https://github.com/mlcommons/mobile_app_open/blob/1f95824a30d6ad9bd0aeaed0ce6005982a643419/docs/environment-setup/env-setup-firebase.md#L8)) https://github.com/mlcommons/mobile_app_open/security/secret-scanning/1

Just found out that we can set up a GitHub Action to deploy the website to Firebase automatically on new PR. I will do the setup for it.

> In this case we need to expose the project's API key and other settings from Firebase. Generally that info is not secure, but let me know if we are...

> @anhappdev it's clear, but how the GitHub will know this to build the app? I will store it as a GitHub secret (https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions)

> @nathanw-mlc here are the env variables for the web app: > > REACT_APP_FIREBASE_WEB_API_KEY REACT_APP_FIREBASE_AUTH_DOMAIN REACT_APP_FIREBASE_DATABASE_URL ... I already added these as GitHub secrets for this repo.

This is the URL for the web UI. https://mobile-app-build-290400.web.app We can also use a custom domain / URL if @nathanw-mlc provides us one.

> > This is the URL for the web UI. https://mobile-app-build-290400.web.app > > We can also use a custom domain / URL if @nathanw-mlc provides us one. > > Hey...

Should this feature be in the app? On a computer, it's quite easy to zip and split the big file, though. For example, on macOS I can zip and split...