UnitsNet icon indicating copy to clipboard operation
UnitsNet copied to clipboard

Leverage Nerdbank.GitVersioning to auto-increment version numbers

Open tmilnthorp opened this issue 2 years ago • 5 comments

Leverage Nerdbank.GitVersioning to auto-increment version numbers

I need your help @angularsen with the NanoFramework items. Not sure if I did it right.

Also I suppose we may need to remove some files (build\bump-version-UnitsNet-minor.bat, etc.)?

tmilnthorp avatar Feb 22 '23 18:02 tmilnthorp

Didn't get to it this weekend, will ping back later.

angularsen avatar Feb 26 '23 20:02 angularsen

I think if ADO was not doing a shallow checkout, this should work as-is.

tmilnthorp avatar Feb 26 '23 20:02 tmilnthorp

@angularsen are you able to edit the ADO build to do a full depth checkout? (Depth 0)

tmilnthorp avatar Mar 03 '23 21:03 tmilnthorp

How do we test this without pushing nugets? Should we create a new master branch to simulate how master would be and disable push to nuget.org on that branch?

  1. Make sure you have nbgv installed locally: dotnet tool install -g nbgv
  2. Checkout master locally and merge in this branch
  3. Run nbgv get-version
  4. git reset origin/master to reset local master

What is the procedure for bumping versions? It seems GitVersioning and their CLI tooling is aimed towards stabilizing releases on new branches, but in UnitsNet it is pretty much about bumping minor versions for every new unit and additive changes. I want to keep it simple, ideally having the CI build bump the minor version for me. Not sure if it can be configured that way, it seems patch version is what is supported for auto-versioning.

Hmmm indeed. Let me see if I can make it get the minor to increment

tmilnthorp avatar Mar 04 '23 15:03 tmilnthorp

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 18 '23 07:06 stale[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] avatar Jul 08 '24 18:07 github-actions[bot]

This PR was automatically closed due to inactivity.

github-actions[bot] avatar Jul 16 '24 02:07 github-actions[bot]