angular_components icon indicating copy to clipboard operation
angular_components copied to clipboard

ChangeDetectionStrategy.OnPush missing in a few components

Open vlin59 opened this issue 5 years ago • 1 comments

I'm on angular: 6.0.0 and angular_components: 1.0.1.

Using the MaterialSelectComponent gives this compile-time warning when the parent uses the OnPush Change Detection Strategy.

"MaterialSelectComponent" doesn't use "ChangeDetectionStrategy.OnPush", but is used by a component that does.

ReorderListComponent and MaterialSelectSearchboxComponent appears to also require it.

I haven't come across anything else in my codebase but more could be missing.

vlin59 avatar Oct 15 '20 22:10 vlin59

Fixed in the latest, Angular-7-compatible ngcomponents

GZGavinZhao avatar Nov 11 '21 07:11 GZGavinZhao