material icon indicating copy to clipboard operation
material copied to clipboard

build: interimElements and Layout code not deterministically ordered

Open Splaktar opened this issue 6 years ago • 1 comments

Bug, enhancement request, or proposal:

Bug

CodePen and steps to reproduce the issue:

CodePen Demo which demonstrates the issue:

https://github.com/angular/bower-material/commit/31ac6b3046de682d60534d7bdfd81d9f48161049#diff-df9d3e2ee1137430619e1984b3c34f3b

Detailed Reproduction Steps:

  1. Merge a change into the master branch
  2. Then check that the code in bower-material/modules/closure/core/core.js is re-ordered

What is the expected behavior?

The order of the code is deterministic.

What is the current behavior?

The order of the code is non-deterministic. In this case, the order of the src/core/services/layouts and src/core/services/interimElement code was swapped.

What is the use-case or motivation for changing an existing behavior?

So that only real changes show up in the module diffs.

Which versions of AngularJS, Material, OS, and browsers are affected?

  • AngularJS: 1.7.8
  • AngularJS Material: 1.1.18-master-d577afd
  • OS: macOS
  • Browsers: Chrome

Is there anything else we should know? Stack Traces, Screenshots, etc.

Related to #11502.

Splaktar avatar May 21 '19 01:05 Splaktar

Lowering priority since g3 sync has stopped.

Splaktar avatar Oct 20 '20 18:10 Splaktar