components icon indicating copy to clipboard operation
components copied to clipboard

refactor: switch output event event classes to interfaces

Open crisbeto opened this issue 8 years ago • 5 comments

Converts the various event classes that we emit through @Output into interfaces in order to generate less compiled code and potentially less objects to garbage collect.

crisbeto avatar Jan 17 '18 19:01 crisbeto

Caretaker note: we should keep an eye out on how many presubmit failures this causes and determine based on that whether it's still worth the trouble.

crisbeto avatar Jan 17 '18 19:01 crisbeto

FYI this fixes part of #7191.

rafaelss95 avatar Jan 18 '18 01:01 rafaelss95

@crisbeto I ran a presubmit on this and found that there are quite a few places where people new their own events in unit tests. Based on that, this would have to be a major change

jelbourn avatar Jan 18 '18 19:01 jelbourn

Any chance to ship this in v6?

rafaelss95 avatar Apr 12 '18 01:04 rafaelss95

This isn't going to make it in for 6.0 since it caused too many breakages inside Google. We should bump it to 7.0

jelbourn avatar Apr 25 '18 20:04 jelbourn

Closing since this is way out of date.

crisbeto avatar Feb 28 '24 08:02 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.