components icon indicating copy to clipboard operation
components copied to clipboard

feat(google-maps): switch to non-deprecated API for clustering and su…

Open OgiSss opened this issue 1 year ago • 6 comments

This commit update map marker cluster and support map marker and map advanced marker.

It's related to: #23695 #24853

OgiSss avatar Apr 11 '24 16:04 OgiSss

@crisbeto Based on your code i have created a PR to support clusters for both markers and advanced markers. I know that the API between old and new clusters are different but in my opinion it's good idea to update library especially that many people waiting for it. And my code support old markers and new markers. Let me know what do you think about it

OgiSss avatar Apr 11 '24 17:04 OgiSss

I don't think that we would want to support both clustering APIs in a single component since it's too much responsibility for one component and it'll make it harder to delete later. I'll see if I can get https://github.com/angular/components/pull/24853 moving again.

crisbeto avatar Apr 12 '24 21:04 crisbeto

@crisbeto I mean I have implemented only one clusterer (the new one) but with support for marker and advanced marker.

OgiSss avatar Apr 13 '24 06:04 OgiSss

@crisbeto support for the "new" markerclusterer is highly appreciated. I think the old one is deprecated now for over 2 years. With the markers beeing deprecated it now makes even less sense to use markerclustererplus.

The new one supports handling for both new and old markers, so I think this PR makes total sense.

I stopped using the angular components years ago, because they didn't support the newest changes with the algorithms and the render function. Thought after upgrading to 17 I can finally use them. But doesn't seem so...

LeLunZ avatar Apr 26 '24 14:04 LeLunZ

Any chance this arrives in v18? I recently started using Angular Google Maps and started with the advanced markers due to the deprecation warning. I would like to use the marker clusters. Should I wait or use the normal markers?

Siddhu-K avatar May 08 '24 16:05 Siddhu-K