components icon indicating copy to clipboard operation
components copied to clipboard

fix(material/form-field): make notch sizing more reliable

Open mmalerba opened this issue 3 years ago • 3 comments

Swap out the current logic for determining when to resize the outline gap, for logic based on ResizeObserver. The current logic tries to guess when the size may need to change based on observing the content, checking after fonts load, etc. But using ResizeObserver should catch more cases.

Also brings the gap calculation logic outside the NgZone to avoid running unnecessary change detections.

mmalerba avatar Nov 18 '22 23:11 mmalerba

Deployed dev-app to: https://ng-dev-previews-comp--pr-angular-components-26028-e02f-qfra092t.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

github-actions[bot] avatar Nov 19 '22 18:11 github-actions[bot]

This is ready for another look

mmalerba avatar Nov 22 '22 23:11 mmalerba

ready for review again

mmalerba avatar Nov 23 '22 21:11 mmalerba

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.