components icon indicating copy to clipboard operation
components copied to clipboard

feat(MatDIalog): Allow specifying MatDialogConfig as part of the dialog component

Open Harpush opened this issue 3 years ago • 0 comments

Feature Description

Currently if there is a dialog which is meant to be used with a specific width, height, autoFocus, disableClose, etc... each and every code that opens that dialog need to specify those values. Even if extracted to a const you still need to remember to pass it.

What I wish to have is the ability to specify on the dialog component itself those configuration options or at least some of them that make sense. Allowing to actually "declare" to the one using - If you pass nothing in the open function config - this is the recommended and default config for this specific dialog. If you do pass a config object it overrides the recommended one.

Use Case

When having a dialog that needs for example to have autoFocus as false always as it handles it inside - everyone using that dialog has to remember to declare this specific config when opening otherwise the dialog won't work as expected. Even if it was extracted to a const - the one opening the dialog still needs to know that const exists and remember to pass it. The suggestion allows the dialog creator to specify the default config.

Harpush avatar Sep 06 '22 06:09 Harpush