components icon indicating copy to clipboard operation
components copied to clipboard

feat(material-experimental/mdc-menu): support density

Open crisbeto opened this issue 5 years ago • 6 comments

Adds support for density to the MDC-based mat-menu.

crisbeto avatar Jan 18 '21 21:01 crisbeto

@jelbourn Do you know if we want to change density of things in an overlay? I remember there being some discussion about not needing to do that, but also maybe it looks weird if the trigger is dense and the popup isnt?

it looks like the spec does show a dense option too: https://material.io/components/menus#specs

mmalerba avatar Jan 21 '21 20:01 mmalerba

https://material.io/design/layout/applying-density.html#usage

Don’t increase the density of components that involve focused tasks, such as interacting with a dropdown menu or picker. Increasing density on components such as date pickers reduces usability by limiting tappable space.

jelbourn avatar Jan 21 '21 20:01 jelbourn

That does seem to conflict with the menu spec. We should raise it to the Material folks

jelbourn avatar Jan 21 '21 20:01 jelbourn

I added an agenda item for our next meeting with them. Will mark this as blocked pending their feedback

mmalerba avatar Jan 21 '21 20:01 mmalerba

I filed a bug with the spec

jelbourn avatar Jan 21 '21 21:01 jelbourn

Did we ever get an answer on this?

crisbeto avatar Feb 28 '21 14:02 crisbeto

Closing this for now given how much the menu has changed since then and how out of date it is.

crisbeto avatar Feb 28 '24 08:02 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.