feat(module:overlay): directive support disposeOnNavigation

[wzhudev]

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[wzhudev]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[wzhudev]

@crisbeto Please check this bug of ng-zorro https://github.com/NG-ZORRO/ng-zorro-antd/issues/1530 and this bug of components itself https://github.com/angular/components/issues/11478.

But I've not tested them with the latest release of CDK.

[crisbeto]

I don't see where the overlay directive is being used in the linked example.

[wzhudev]

@crisbeto Sorry for the misleading.

Material seems just missing a property here.

But in ng-zorro-antd we use Overlay in a declarative way.

[crisbeto]

That was my point. Wouldn't that component that is used declaratively be destroyed when you navigate to a different route?

[wzhudev]

That was my point. Wouldn't that component that is used declaratively be destroyed when you navigate to a different route?

I am afraid not, according to the reproductions provided in https://github.com/NG-ZORRO/ng-zorro-antd/issues/1530.

The user applied a router reuse strategy here so it seemed that the component is not destroyed?

[crisbeto]

This was done in #27672. Closing.

[angular-automatic-lock-bot[bot]]

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}