components icon indicating copy to clipboard operation
components copied to clipboard

fix(autocomplete): marking element as touched too early when clicking on options

Open crisbeto opened this issue 7 years ago • 2 comments

Currently we mark the autocomplete's CVA as touched on each blur event, which can happen a little too early if the user holds their pointer while clicking on an item, causing the form validation to show up too early. These changes defer marking the element as touched until the panel has closed.

Fixes #13732.

crisbeto avatar Oct 23 '18 18:10 crisbeto

I see that you just added the pr: merge ready label, but the following checks are still failing:     failure status "continuous-integration/travis-ci/pr" is failing     failure status "ci/circleci: e2e_tests" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

ngbot[bot] avatar Oct 24 '18 22:10 ngbot[bot]

Is there any news?

francesconi avatar Sep 10 '19 14:09 francesconi