components icon indicating copy to clipboard operation
components copied to clipboard

feat: add support for strictPropertyInitialization

Open crisbeto opened this issue 7 years ago • 9 comments

Enables strictPropertyInitialization and fixes all of the resulting compilation errors.

Fixes #13329.

crisbeto avatar Sep 27 '18 15:09 crisbeto

@jelbourn this one's finally ready to go. It ended up introducing more than 800 compilation errors.

crisbeto avatar Sep 28 '18 20:09 crisbeto

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. Please help to unblock it by resolving these conflicts. Thanks!

ngbot[bot] avatar Oct 02 '18 20:10 ngbot[bot]

Ack on the ones you replied on

jelbourn avatar Oct 08 '18 21:10 jelbourn

@jelbourn I've rebased it, fixed some more issues from master and addressed the feedback.

crisbeto avatar Oct 13 '18 10:10 crisbeto

Switching this to a patch, but we should evaluate based on the presubmit.

crisbeto avatar Oct 18 '18 19:10 crisbeto

Is this still something you want to try to get in?

andrewseguin avatar Jun 12 '20 19:06 andrewseguin

I don't think getting this massive PR in one go is practical anymore. I left it here mostly as a reminder that we need to do this eventually.

crisbeto avatar Jun 12 '20 19:06 crisbeto

Is there a JIRA item associated with it? I suggest we close this but link to it from that item

andrewseguin avatar Jun 15 '20 19:06 andrewseguin

You can close and make sure it's in jira

jelbourn avatar Jun 15 '20 21:06 jelbourn

Closing since this is way out of date.

crisbeto avatar Feb 28 '24 08:02 crisbeto

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.