angular icon indicating copy to clipboard operation
angular copied to clipboard

docs(language-service): fix link URLs

Open dzhavat opened this issue 1 year ago • 4 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [x] Documentation content changes
  • [ ] angular.dev application / infrastructure changes
  • [ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

Other information

dzhavat avatar Oct 10 '24 08:10 dzhavat

Hi, could you reformat the file with yarn ng-dev format files packages/language-service/src/quick_info_built_ins.ts to satisfy the linting job. Thank you.

JeanMeche avatar Oct 10 '24 10:10 JeanMeche

@JeanMeche thanks for your help. Should be fixed now :)

dzhavat avatar Oct 10 '24 11:10 dzhavat

Could you please squash both commits, we'd like the change to be a single commit.

JeanMeche avatar Oct 10 '24 13:10 JeanMeche

Should be ok now 🙂

dzhavat avatar Oct 10 '24 19:10 dzhavat

This PR was merged into the repository by commit 9097b734e5b4a942d821345fa1879f239957284b.

The changes were merged into the following branches: main, 18.2.x

devversion avatar Oct 16 '24 14:10 devversion

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.