angular.js icon indicating copy to clipboard operation
angular.js copied to clipboard

ngAnimate assumes transition is linear instead of using the value in CSS

Open wesleycho opened this issue 10 years ago • 4 comments

There are two scenarios which are not being caught - the easing function in CSS when the transition is specified in the transition CSS property, and the easing function if it is specified in the transition-timing-function property.

Here is a stripped down example of the transition-timing-function situation.

Here is a plnkr, a stripped down example of the transition situation.

Note that $animateCss (& $animate as well it turns out) assumes that the easing function is linear instead of ease here.

This is a regression from 1.3.x

wesleycho avatar Aug 22 '15 21:08 wesleycho

Thanks for reporting @wesleycho! Contrary to many other ngAnimate bug, this looks like it's not too difficult to fix. Do you think you could give a PR a shot?

Narretz avatar Aug 24 '15 13:08 Narretz

Sure, I'll try to put together a PR today

wesleycho avatar Aug 24 '15 14:08 wesleycho

Here's a plnkr that you can use http://plnkr.co/edit/rHRFzotMG5pZGeBKF8Lw?p=preview

trajano avatar Sep 05 '15 00:09 trajano

We had some issues on Travis, so the commit was reverted

Narretz avatar Dec 10 '15 13:12 Narretz