angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

generate app-shell with inline styles and templates

Open stramel opened this issue 8 years ago • 6 comments

Versions

Angular CLI: 1.6.3
Node: 8.9.1
OS: linux x64
Angular: 5.1.2
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

@angular/cli: 1.6.3
@angular/platform-server: error
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.3
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.4.2
webpack: 3.10.0

Desired behavior

It would be nice to be able to use the --inline-styles and --inline-templates flags on the ng generate appShell command. I have all the rest of my app generated with inline templates and styles so it is weird that I can't do that with the app-shell as well.

stramel avatar Jan 03 '18 16:01 stramel

This is not a bad idea, thanks for submitting.

Brocco avatar Jan 08 '18 18:01 Brocco

hi @alan-agius4 , is this something still needed/ nice to be added to the schematics? If so would we like to have display-block also added to the list next to inline-template and inline-styles

Jefiozie avatar Feb 23 '21 07:02 Jefiozie

I am inclining towards leaving this out for the following reasons;

  1. You can configure these options in the in the angular.json.
  2. Community demand/response has been very low for this.
  3. Increasing code complexity and API surface.
  4. Unlike a component an app-shell is only generated one time, and hence It's trivial to change.

alan-agius4 avatar Feb 23 '21 08:02 alan-agius4

Okay, then I will leave the ticket as it is thanks for responding, should we close the issue?

Jefiozie avatar Feb 23 '21 08:02 Jefiozie

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

angular-robot[bot] avatar Feb 01 '22 17:02 angular-robot[bot]

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

angular-robot[bot] avatar Feb 21 '22 13:02 angular-robot[bot]

Closing due to lack of interest from the community for this feature. Let's re-consider if things change.

alan-agius4 avatar May 10 '23 11:05 alan-agius4

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.