angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

new library public-api.ts file not using component type declared on angular.json's schematics

Open johalternate opened this issue 1 year ago • 1 comments

Which @angular/* package(s) are the source of the bug?

Don't known / other

Is this a regression?

No

Description

When I create a new library the default component inside of the lib folder takes its type from the component schematic declared on angular.json. If for example my angular.json looks like this:

{
    //...
    "newProjectRoot": "projects",
    //...
    "schematics": {
        "@schematics/angular:application": {
          "style": "scss",
          "inlineTemplate": true,
          "inlineStyle": true,
          "ssr": false
        },
        "@schematics/angular:component": {
          "changeDetection": "OnPush",
          "type": "Cmp",
          "inlineStyle": true,
          "inlineTemplate": true,
          "style": "scss"
        }
    }
}

After creating a library using ng generate library foo-library, the new library includes an empty dummy FooLibraryCmp inside the projects/foo-library/src/lib/foo-library.cmp.ts. However, the contents of projects/foo-library/src/public-api.ts look like this:

/*
 * Public API Surface of foo-library
 */

export * from './lib/foo-library.service';
export * from './lib/foo-library.component'; // uses .component instead of .cmp

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in (run ng version)

Angular CLI: 17.1.1
Node: 18.18.0
Package Manager: npm 9.6.6
OS: win32 x64

Angular: 17.1.1
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, platform-server
... router, ssr

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1701.1
@angular-devkit/build-angular   17.1.1
@angular-devkit/core            17.1.1
@angular-devkit/schematics      17.1.1
@schematics/angular             17.1.1
ng-packagr                      17.1.2
rxjs                            7.8.1
typescript                      5.2.2
zone.js                         0.14.3

Anything else?

No response

johalternate avatar Jan 28 '24 01:01 johalternate

I would love to take a shot at this issue for my first contribution to angular, in fact, I already have a somewhat working solution on my fork (https://github.com/johalternate/angular-cli/commit/ee48a807b78077c97a25e3a69deeae64b2d6399b).

But Im unable to write a test for it because I cant find a way of providing default schematics config to a workspace tree created using SchematicTestRunner.runSchematic('workspace', <some-options>).

Any idea about how can I test my solution?

johalternate avatar Jan 25 '25 01:01 johalternate