angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

refactor(@angular/cli): convert quicktype_runner to ts

Open santoshyadavdev opened this issue 2 years ago • 1 comments

PR Checklist

Please check to confirm your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [x] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] Other... Please describe:

What is the current behavior?

The file had a TODO This file is pure JavaScript because Bazel only support compiling to ES5, while quicktype is ES2015. Now bazel supports 2015 as per config

Issue Number: N/A

What is the new behavior?

Migrate the file to typescript

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

Other information

santoshyadavdev avatar Dec 06 '23 21:12 santoshyadavdev

I know this will have more work, opening the PR to get some feedback

santoshyadavdev avatar Dec 06 '23 21:12 santoshyadavdev

Happy to accept a PR that changes this to TypeScript. Although truth to be told, there is very little benefits of adding converting this.

alan-agius4 avatar Mar 06 '24 13:03 alan-agius4

This issue has been automatically locked due to inactivity. Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.