angular-cli icon indicating copy to clipboard operation
angular-cli copied to clipboard

ng generate library virtusUI --style=scss gives an error

Open AlexanderKozhevin opened this issue 7 years ago • 8 comments

- [ ] bug report -> please search issues before submitting
- [x] feature request

It would be cool to generate library with SCSS system.

ng generate library virtusUI --style=scss

Now I'm getting an error

Schematic input does not validate against the Schema: {"style":"scss","entryFile":"public_api","prefix":"lib","skipPackageJson":false,"skipTsConfig":false}
Errors:

  Data path "" should NOT have additional properties(style).

AlexanderKozhevin avatar Jun 17 '18 23:06 AlexanderKozhevin

What version of packages are you using? Use: ng --version

As I managed to get this working without any problem

ng generate library virtusUI --style=scss
CREATE projects/virtus-ui/karma.conf.js (968 bytes)
CREATE projects/virtus-ui/ng-package.json (185 bytes)
CREATE projects/virtus-ui/ng-package.prod.json (158 bytes)
CREATE projects/virtus-ui/package.json (169 bytes)
CREATE projects/virtus-ui/src/public_api.ts (167 bytes)
CREATE projects/virtus-ui/src/test.ts (700 bytes)
CREATE projects/virtus-ui/tsconfig.lib.json (769 bytes)
CREATE projects/virtus-ui/tsconfig.spec.json (246 bytes)
CREATE projects/virtus-ui/tslint.json (317 bytes)
CREATE projects/virtus-ui/src/lib/virtus-ui.module.ts (235 bytes)
CREATE projects/virtus-ui/src/lib/virtus-ui.component.spec.ts (643 bytes)
CREATE projects/virtus-ui/src/lib/virtus-ui.component.ts (263 bytes)
CREATE projects/virtus-ui/src/lib/virtus-ui.service.spec.ts (387 bytes)
CREATE projects/virtus-ui/src/lib/virtus-ui.service.ts (137 bytes)
UPDATE angular.json (4829 bytes)
UPDATE package.json (1457 bytes)
UPDATE tsconfig.json (495 bytes)
added 88 packages in 27.604s

Mine are;

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 6.0.8
Node: 9.9.0
OS: darwin x64
Angular: 6.0.5
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.6.8
@angular-devkit/build-angular      0.6.8
@angular-devkit/build-ng-packagr   0.6.8
@angular-devkit/build-optimizer    0.6.8
@angular-devkit/core               0.6.8
@angular-devkit/schematics         0.6.8
@angular/cli                       6.0.8
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.0.8
@schematics/angular                0.6.8
@schematics/update                 0.6.8
ng-packagr                         3.0.2
rxjs                               6.2.1
typescript                         2.7.2
webpack                            4.8.3

alan-agius4 avatar Jun 18 '18 06:06 alan-agius4

Oh, ok, I'll try to downgrade. @alan-agius4

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 6.1.0-rc.0
Node: 8.11.1
OS: darwin x64
Angular: 6.0.5
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.7.0-rc.0
@angular-devkit/build-angular      0.7.0-rc.0
@angular-devkit/build-ng-packagr   0.7.0-rc.0
@angular-devkit/build-optimizer    0.7.0-rc.0
@angular-devkit/build-webpack      0.7.0-rc.0
@angular-devkit/core               0.7.0-rc.0
@angular-devkit/schematics         0.7.0-rc.0
@angular/cli                       6.1.0-rc.0
@ngtools/json-schema               1.1.0
@ngtools/webpack                   6.1.0-rc.0
@schematics/angular                0.7.0-rc.0
@schematics/update                 0.7.0-rc.0
ng-packagr                         3.0.2
rxjs                               6.2.1
typescript                         2.7.2
webpack                            4.9.2

AlexanderKozhevin avatar Jun 18 '18 07:06 AlexanderKozhevin

Yes, downgraded version works just fine. But version Angular CLI: 6.1.0-rc.0 has some issues.

AlexanderKozhevin avatar Jun 18 '18 13:06 AlexanderKozhevin

As of now, the component created for a library has inline style and inline template, so I am marking this as a feature request to be considered later.

Brocco avatar Jun 26 '18 19:06 Brocco

[Solution] On angular.json, find your project lib and paste this bloco before "architect": { param:

"schematics": {
        "@schematics/angular:component": {
          "styleext": "scss"
    }
},

Save. Use ng generate component foo --project=your-lib to generate a new componet has a scss file.

regivaldo avatar Sep 21 '18 19:09 regivaldo

inline style and template are the defaults:

https://github.com/angular/angular-cli/blob/27d1200b187185be5ab0f79995dee6ccd6791d92/packages/schematics/angular/library/index.ts#L227-L236

kyliau avatar May 27 '20 00:05 kyliau

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

angular-robot[bot] avatar Feb 01 '22 18:02 angular-robot[bot]

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

angular-robot[bot] avatar Feb 21 '22 13:02 angular-robot[bot]