ui-sortable icon indicating copy to clipboard operation
ui-sortable copied to clipboard
verified publisher icon angular-ui

syntax refactor

Open wuliupo opened this issue 9 years ago • 3 comments

Only syntax refactor,

  1. remove unused return null;
  2. a in b write in b.a will more clear;
  3. wrappers only have one property helper;
  4. _restore and _destroy were simplified as delete item.sortable.

wuliupo avatar Jul 20 '16 11:07 wuliupo

Coverage Status

Coverage decreased (-0.6%) to 99.383% when pulling b68ae26f0eaad6ca7bb647f5887b984eb3da0b9d on wuliupo:master into 4bb4493f18faa5c4a9aaa3780e4b173ccf5a1ea2 on angular-ui:master.

coveralls avatar Jul 20 '16 11:07 coveralls

Coverage Status

Coverage decreased (-0.6%) to 99.383% when pulling 8e728b45ed8a9175f185d6440c5b49b24b552442 on wuliupo:master into 4bb4493f18faa5c4a9aaa3780e4b173ccf5a1ea2 on angular-ui:master.

coveralls avatar Jul 20 '16 12:07 coveralls

Please don't create a hure diff. Try not moving methods until the initial refactor gets reviewed. Keep in mind that targeting the absolute min number of code lines can hurt the debug-ability of the code. Also refactoring chained method invocations to be in the same line can hurt the readability of the code.

thgreasi avatar Jul 20 '16 12:07 thgreasi