Fixes for id attar + add click attr for callback.

Open developer88 opened this issue 11 years ago • 4 comments

First of all - with the latest version of jqplot this directive is not working for me, because it call $(element).jqplot, but according to official jqplot's documentation there is only one appropriate way - $.jqplot('elemente's id' ....); Second - I have added chart-click attribute to pass a function that will be called when event 'jqplotDataClick' is fired.

Apr 01 '14 05:04 developer88

Smth wrong with Travis, but definitely, that is not my fault.

Apr 02 '14 03:04 developer88

I will fix these Travis errors tonight - other than these minor issues I've commented on, I like this PR, and am willing to merge this and tag a new release when this is tidied up.

Apr 17 '14 20:04 wesleycho

There should be a test added for the binding of the callback as well, to test that it properly sets the correct binding and unsets the old binding.

Apr 17 '14 21:04 wesleycho

Any time this fix will be finalized and committed ?

Dec 20 '15 09:12 tohyf