ui-ace icon indicating copy to clipboard operation
ui-ace copied to clipboard

No license in javascript

Open paulberg opened this issue 11 years ago • 6 comments

The javascript file does not contain any comment as to the source of the code or the license it is under. This makes it difficult for end users to see the license. Could this be added to the source files?

paulberg avatar Sep 22 '14 23:09 paulberg

Yes.

douglasduteil avatar Jan 08 '15 03:01 douglasduteil

Looks like this is already handled by the presence of LICENSE and the license property in bower.json? Or is this adding a banner to the top of the file?

richleland avatar Jan 08 '15 04:01 richleland

I guess @paulberg wants a banner on the top of each dist files right ? A little bit of grunt concat will do it :+1:

douglasduteil avatar Jan 08 '15 05:01 douglasduteil

https://github.com/mattstyles/grunt-banner works well too.

richleland avatar Jan 08 '15 05:01 richleland

Yeah look nice but I would like to tackle the IIFE problem in the same line. So I would be cool to have on the dist task

// The banner
/* bla bla bla */

// The IIFE stuff
(function(window, document, undefined) {'use strict';

  // The src content
  angular.module...

// The final IIFE stuff
})(window, document);

douglasduteil avatar Jan 08 '15 05:01 douglasduteil

What you think @richleland ?

douglasduteil avatar Jan 08 '15 05:01 douglasduteil