Ning Xie comments

Results 71 comments of


                                            Ning Xie

Dots ini notation

@fabriziogiordano I think you can refactor this one into this: - a `production` ini file - `ftp` and `db` section in `production` ini file - put `host`, `port` and `user`...

[Misc] make get_class check for Executor instead of ExecutorBase

@comaniac @njhill ptal.

[MISC] add cpu_kvcache_space_bytes to CacheConfig

I do not know why pre-commit will complains about files not changed in this pr: Will update to make pre-commit green.

[Misc] add vllm_config in init

Seems ci has some flakes, force push to re-run ci.

[Misc] add vllm_config in init

/cc @comaniac ptal

[CI] change spell checker from codespell to typos

> Overall this looks reasonable to me. Can you remove the `codespell` config from `pyproject.toml`? @DarkLight1337 Done.

[CI] change spell checker from codespell to typos

> I think it will be annoying and error-prone if developers need to define functional exceptions like this during their work Yes. this is true. Some trade-off needs to be...

[CI] change spell checker from codespell to typos

It seems that most special escapes in spell checking are about cuda and nvml. https://github.com/vllm-project/vllm/pull/18711/files#diff-51afc5d77bc899fd07f13239bccc4c8042af7062b994c4ce493d8123f905f5a4R21-R48 Other changes in this PR are clean and clear enough. There are two options about...

[CI] change spell checker from codespell to typos

/cc @DarkLight1337 @mgoin

[CI] change spell checker from codespell to typos

Some ci test about speculative decoding still failed, will fix it asap.