brotli icon indicating copy to clipboard operation
brotli copied to clipboard

Shared dictionary support?

Open espoal opened this issue 3 years ago • 4 comments

In theory google/brotli has support for shared dictionaries. In practice I've not seen any example anywhere.

Does this package support shared dictionaries? Could you maybe provide an example?

espoal avatar Oct 07 '22 21:10 espoal

Brotli uses a pre-defined static dictionary. I don't think there is any support for using user-generated dictionaries like zstd does.

andybalholm avatar Oct 07 '22 21:10 andybalholm

Oh, now I see that a shared dictionary feature was added a while back. My Go version of the library doesn't have any support for it.

andybalholm avatar Oct 07 '22 21:10 andybalholm

Is there any plan to add support? If I understand correctly, this project is generated via c2go so in theory it should be possible to add (automatically?) the API needed.

Or maybe you tell me there's a lot of legwork to do?

espoal avatar Oct 07 '22 21:10 espoal

It was generated with c2go, but changes have been made since. We can't just regenerate it from the C version now. I don't have any plans to add it, but pull requests are welcome.

andybalholm avatar Oct 07 '22 21:10 andybalholm