media icon indicating copy to clipboard operation
media copied to clipboard

Set `RequestMetadata` on `DownloadRequest`

Open nplasterer opened this issue 3 years ago • 2 comments

You can see more context here: https://github.com/androidx/media/issues/143

We need requestMetadata on all mediaItems in order for the MediaSession.Callback to be able to correctly set the localConfiguration. Previously downloaded items did not have that set. Not sure how exactly you want to solve this but figured I'd push up a commit with what I had in mind.

nplasterer avatar Aug 09 '22 00:08 nplasterer

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 09 '22 00:08 google-cla[bot]

Just wanted to note that I will be out on vacation for the next two weeks so if I'm not responding it's not because I don't want this issue fixed it's just that I'm away from my keyboard. Thanks!

nplasterer avatar Aug 11 '22 17:08 nplasterer

I was able to accomplish this without this change see comment here: https://github.com/androidx/media/issues/143

nplasterer avatar Aug 29 '22 18:08 nplasterer