sunflower icon indicating copy to clipboard operation
sunflower copied to clipboard

Any Plan to add Android Slice support?

Open saurabhkpatel opened this issue 7 years ago • 8 comments

It would be great if we integrate Android Slices support in this sample application.

I can start working on it. I read about slices and built the Android Slices demo, check here. Can we discuss the one-two use-case and I'll start working on it?

saurabhkpatel avatar Sep 07 '18 03:09 saurabhkpatel

I have the same idea before, maybe you can create a branch on your side and letz take a look 👍

XinyueZ avatar Sep 07 '18 07:09 XinyueZ

@XinyueZ Thanks !! Do you want to discuss some use-case and I'll start working on a different branch? Let me create a small PR or branch which has basic support + one basic slice.

saurabhkpatel avatar Sep 07 '18 15:09 saurabhkpatel

🤝 great, glad to see some progress @saurabhkpatel. My suggestion is that firstly make a list or a grid to show current plants in the garden. Actually, the coding is one new file of content slice provider and manifest change. @tiembo how 's your side?

XinyueZ avatar Sep 07 '18 17:09 XinyueZ

Ya, there will be a manifest change and a new sliceProvider file which handles it. We can create add more sliceProvider eventually, but as of now, one is good enough. Let's wait until @tiembo comment on it.

saurabhkpatel avatar Sep 07 '18 18:09 saurabhkpatel

Hi @saurabhkpatel and @XinyueZ - there are plans to add Slice to Sunflower but not in the near term. To learn more about Slices in the meantime check out the Slice samples on GitHub.

tiembo avatar Sep 14 '18 21:09 tiembo

@tiembo: do you think If I start thinking about a small use-case and start preparing sunflower to adopt slices?

saurabhkpatel avatar Oct 19 '18 23:10 saurabhkpatel

@saurabhkpatel what would the use case look like?

tiembo avatar Oct 19 '18 23:10 tiembo

@tiembo Search for a plant and add water to it without opening an application. What do you think about this use-case?

saurabhkpatel avatar Dec 24 '18 20:12 saurabhkpatel