ndk-samples icon indicating copy to clipboard operation
ndk-samples copied to clipboard

Usability improvements for hello-vulkan sample

Open kocdemir opened this issue 1 year ago • 3 comments

Move class functions into a cpp file in a separate commit to improve readability for the project.

Remove redundant functions and calls Report validation layer messages to logcat Auto-disable validation layers when not found Feature support checks to avoid validation failures Rename some function and variables to fix linter and name shadowing warnings Extra logging to help with debugging

kocdemir avatar Feb 26 '24 11:02 kocdemir

@DanAlbert I've separated the previous PR into 2 commits in this one to ease the review. Thanks

kocdemir avatar Feb 26 '24 11:02 kocdemir

It's probably going to be a while before I have the time to review this. I can't review and merge half of a PR. If the 7 things this PR was doing were 7 PRs, I'd probably be able to deal with one or two a day. If it's one PR it's going to have to wait until I have time to review the whole thing, and I don't even know Vulkan. It won't happen any time soon.

DanAlbert avatar Feb 26 '24 20:02 DanAlbert

Sure, this is not urgent and not changing the behavior much. Original owner of the sample, @GOOG-sergiu, can help with reviewing Vulkan related changes. Thank you!

kocdemir avatar Feb 27 '24 13:02 kocdemir