Rewrite codelab in Compose
Summary of Changes
Hello @cy245, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request represents a major architectural shift, refactoring the entire codelab application to leverage Jetpack Compose for its UI. The change aims to modernize the codebase, improve maintainability, and align with current Android development best practices. While the UI layer is completely revamped, the underlying credential management functionality is preserved, with new ViewModel layers facilitating interaction between the UI and the credential APIs.
Highlights
- UI Framework Migration: The application's user interface has been completely rewritten from a Fragment-based architecture to Jetpack Compose, introducing new Composable screens for main, sign-up, sign-in, and home views.
-
Build Configuration Updates: The project's
compileSdkandtargetSdkhave been upgraded to version 35, along with updates to the Kotlin compiler extension and Android Gradle Plugin versions. Jetpack Compose build features and dependencies have been integrated. -
Navigation System Overhaul: The navigation logic has been migrated from Fragment transactions to
androidx.navigation.compose, utilizing aNavHostand a sealed class for defining navigation routes. -
Credential Management Utilities: New utility files (
CredentialManagerUtil.kt,JsonProvider.kt) and ViewModels (SignInViewModel.kt,SignUpViewModel.kt) have been introduced to encapsulate credential manager API calls and JSON data handling, aligning with the Compose UI and MVVM pattern. -
Asset and String Resource Changes: The
rpIdandrp.namein theAuthFromServerandRegFromServerassets have been updated. Numerous new string resources have been added to support the text content of the new Compose UI.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.