connectivity-samples icon indicating copy to clipboard operation
connectivity-samples copied to clipboard

Show `ProgressDialog` while reconnecting to a device from the `DeviceControlActivity`

Open codingjeremy opened this issue 6 years ago • 6 comments

Issue by tfKamran Tuesday Nov 24, 2015 at 12:37 GMT Originally opened as https://github.com/android/android-BluetoothLeGatt/pull/9


Fixes issue #8


This change is Reviewable


tfKamran included the following code: https://github.com/android/android-BluetoothLeGatt/pull/9/commits

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by googlebot Tuesday Nov 24, 2015 at 12:37 GMT


Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by tfKamran Tuesday Nov 24, 2015 at 13:08 GMT


I've already signed it, if not my email account, then at least my GitHub username should have matched.

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by mitchross Monday Mar 21, 2016 at 20:02 GMT


@tfKamran you need to reply "I signed it!"

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

Comment by ryanseys Monday Mar 21, 2016 at 20:47 GMT


No, some of the commits just don't have an email (you can see this by seeing the commits aren't associated with an email in the commits panel of this PR).

Or just look at https://github.com/googlesamples/android-BluetoothLeGatt/commit/3556ca61044c4ddf49317c0ab9c8c4897e1657c9.patch and see that the commit doesn't have an email in the From field.

screen shot 2016-03-21 at 1 47 53 pm

codingjeremy avatar Sep 17 '19 00:09 codingjeremy

I signed it!

tfKamran avatar Sep 17 '19 06:09 tfKamran

I think I made that commit from a temporary work station which was not setup properly, my bad.

Is there a way we can add email to that commit now? It would be [email protected].

tfKamran avatar Sep 17 '19 06:09 tfKamran