architecture-samples icon indicating copy to clipboard operation
architecture-samples copied to clipboard
verified publisher icon android

Migrate to KSP

Open tunjid opened this issue 2 years ago • 5 comments

Replace usages of KAPT with KSP as appropriate:

  • [x] Move Room to KSP
  • [ ] Move Hilt to KSP

tunjid avatar Mar 25 '23 20:03 tunjid

@tunjid Hey, I can take this issue, can you please assign it to me.

AnirudhPudari avatar Apr 08 '23 19:04 AnirudhPudari

@AnirudhPudari all yours!

tunjid avatar Apr 08 '23 20:04 tunjid

@tunjid Hi, I have made the changes as required. Please review. I was only able to migrate room to KSP. Hilt still doesn't have the support yet as mentioned here in list of supported libraries docs https://kotlinlang.org/docs/ksp-overview.html#supported-libraries. The issue tracker has no ETA provided on Hilt support till now since 2021.

Currently with this change we still will have to keep KAPT to support hilt. would you suggest keeping both KAPT and KSP or should we wait till hilt gets the KSP support ?

AnirudhPudari avatar Apr 09 '23 19:04 AnirudhPudari

@AnirudhPudari I've merged your PR, thanks again. I've also updated the tasks to show one of the items has been completed.

tunjid avatar Apr 11 '23 09:04 tunjid

@tunjid Thank you 😊

AnirudhPudari avatar Apr 11 '23 11:04 AnirudhPudari