android
Add TextView.updateCompoundDrawable... functions
@tomaszrykala shouldn't those extensions be placed under androidx.widget package?
Sorry, I completely forgot about this PR, my bad! Looking at it again, I think this extension should work like ViewGroup.updateMargins. For instance if calling:
udpateCompoundDrawables(left=whatever, right=whatever)
Then top and bottom should remain unchanged instead of becoming null. What do you think?
@romainguy I could try that, although my original intention for this change was to remove the boilerplate of additional drawables to set when you really want to set one, via default arguments.
What if we have two sets of updateCompoundDrawable... methods :
- updateCompoundDrawable... - behaving like the ones in this PR
- updateCompoundDrawablePreserving... - that preserves any existing values
Option two: allow additional Boolean argument, that would toggle this preserve/overwrite behaviour, eg.
fun TextView.updateCompoundDrawables(
start: Drawable? = null,
top: Drawable? = null,
end: Drawable? = null,
bottom: Drawable? = null,
keepExisting: Boolean = false
) {
// if (keepExisting) ...
setCompoundDrawables(start, top, end, bottom)
}
What do you think?
Neither of those behaviors are intuitive for a method named "update". I agree that this method should only alter the drawables which are supplied. This is also solves your case of only setting a subset, as they default to not present anyway.
It's easy enough to do this with methods that take drawables as arguments eg:
fun TextView.updateCompoundDrawables(
start: Drawable? = compoundDrawables[0],
top: Drawable? = compoundDrawables[1],
end: Drawable? = compoundDrawables[2],
bottom: Drawable? = compoundDrawables[3]
) {
setCompoundDrawables(start, top, end, bottom)
}
but how to do this with methods that take @DrawableRes Ints in? , meaning how do I ensure that drawables aren't being overwritten? Call the methods that take in Drawables internally instead? In code like the follwing the getDrawable() calls are cause @Deprecated warnings, and theme one that takes Theme as an argument is from API 21.
/**
* Updates this TextView's Drawables. This version of the method allows using named parameters
* to just set one or more Drawables. Use 0 if you do not want a Drawable there.
*
* @see TextView.setCompoundDrawablesWithIntrinsicBounds
*/
fun TextView.updateCompoundDrawablesWithIntrinsicBounds(
@DrawableRes start: Int = -1,
@DrawableRes top: Int = -1,
@DrawableRes end: Int = -1,
@DrawableRes bottom: Int = -1
) {
setCompoundDrawablesWithIntrinsicBounds(
if (start == -1) compoundDrawables[0] else if (start == 0) null else resources.getDrawable(start),
if (top == -1) compoundDrawables[1] else if (top == 0) null else resources.getDrawable(top),
if (end == -1) compoundDrawables[2] else if (end == 0) null else resources.getDrawable(end),
if (bottom == -1) compoundDrawables[3] else if (bottom == 0) null else resources.getDrawable(bottom)
)
Yep. That's what TextView does except we'll use ContextCompat.getDrawable.
Can I have an update from the maintainers please if there's anything left to do?
Sorry Tomasz, nothing left to do at the moment, I just need to find a bit of time to play with the change
Hi Tomasz,
Sorry but I'm unclear why I have an email from you. I'm too busy at moment with a bug in the Intel CPU architecture.
It affects nearly every computer on the planet. See google project zero & press reports about CPU design flaw.
Regards, Dave On 11 Jun 2018 22:50, "Tomasz Rykała" [email protected] wrote:
4 months later still nothing. A bit disappointing :(
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/android/android-ktx/pull/159#issuecomment-396398732, or mute the thread https://github.com/notifications/unsubscribe-auth/AiqCH1-uSAamIhBAmDxvncU7SiWH8ONwks5t7uY1gaJpZM4R6R3V .
