json-diff icon indicating copy to clipboard operation
json-diff copied to clipboard

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default

Open venkatpoluri opened this issue 3 years ago • 5 comments

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default. This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to: - add a fallback 'resolve.fallback: { "assert": require.resolve("assert/") }' - install 'assert' If you don't want to include a polyfill, you can use an empty module like this: resolve.fallback: { "assert": false }

venkatpoluri avatar Dec 15 '22 14:12 venkatpoluri

Thank you @venkatpoluri -- this is a bit out of my league -- can you help by providing a PR to fix this? -Thank you.

ewoudenberg avatar Feb 14 '23 04:02 ewoudenberg

This is a Webpack build issue, not related to the package.

An easy fix here would be to install this plugin in any dependent application: https://www.npmjs.com/package/node-polyfill-webpack-plugin

JasonXian avatar Feb 27 '23 21:02 JasonXian

Another vote for a solution on this one.

My relevant package.json: "@ionic/core": "^6.2.7", "@ionic/vue": "^6.2.7", "@types/json-diff": "^1.0.0", (thank you for this package) "json-diff": "^1.0.6", "vue": "^3.2.39", "webpack": "^5.74.0"

mattluttrell avatar Aug 22 '23 18:08 mattluttrell

Dear JSON-diff users:

If anyone can provide a pull request for this feature, I would be happy to merge and publish it. The proper fix for this is a bit beyond my JS tool chain skills.

Thank you, Eric

ewoudenberg avatar Aug 22 '23 18:08 ewoudenberg