Convert-Pluggable denied despite new first-come packages inside

[dagolden]

Per http://www.nntp.perl.org/group/perl.modules/2014/03/msg89623.html, Convert-Pluggable uploads are getting denied for lack of dist name permissions, but it contains new packages of the correct name. The tarball is odd, with development files (e.g. blib) included, but I don't know if that's related. I've answered his email with some explanation.

[rjbs]

It's interesting that he gets that error, but PAUSE will never index a dist with blib. From PAUSE::dist:

    push @m, $tf->format(qq{The distribution contains a blib/
      directory and is therefore not being indexed. Hint:
      try 'make dist'.});

There are tests for adding new namespaces which seem to work, and I'm guessing we could find a dist newly created in the last week for further testing. I think the real bug here is going to end up being that we reported the wrong reason.

[elohmrow]

the issue was as @dagolden stated - having never put anything on cpan before, i simply did a tar -czvf of the dev tree and uploaded that. on his advice, i re-named the dir to Convert-Pluggable-0.015, ran make dist on it after make test and uploaded that in stead. it did not send me a fail message this time, so i dunno if that's cuz you fixed it lightening-fast, or if it was my fault all along for uploading the wrong thing.

[rjbs]

Looking at mldistwatch.pm, I find:

          $dio->examine_pms;      # will switch user

          my $main_pkg = $dio->_package_governing_permission;

          if ($self->_userid_has_permissions_on_package($userid, $main_pkg)) {
            $dbh->commit;
          } else {
            $dio->alert(
              "Uploading user has no permissions on package $main_pkg"
            );
            $dio->{NO_DISTNAME_PERMISSION} = 1;
            $dbh->rollback;
          }

I think that it's finishing the examine_pm (which is the real "index" step) and finding that the permissions have not been added — because of blib — and then therefore setting NO_DISTNAME_PERMISSION. That (NO_DIST..) is the first branch checked when deciding what error message to report, and so is taking precedence over the HAS_BLIB error, which is almost certainly also present.

[rjbs]

I'm probably done looking at this ticket for tonight, but it should remain open, signifying the problem I've described where failure to index causes the distname-permission branch to be entered when another branch is more relevant.

Unfortunately, while we accumulate warnings in a simple way, we do not accumulate errors that way. Each is stored in a different place, and we look for each one in turn. It would be better if we had a simple queue of errors to report.

[elohmrow]

@rjbs @dagolden quick question - i successfully uploaded several (slightly different) versions of this today ... http://search.cpan.org/~elohmrow/Convert-Pluggable-0.017/ ... but now i see "** UNAUTHORIZED RELEASE **" plastered on that page. that was not there before 0.017 (most recent). Now, in order to make this work with something else, I broke the tests. The tests all passed up to 0.016 (most recent - 1), and this message was not there before.

am i correct to assume that this message popped up because my test suite didn't pass? and, does that mean most recent version won't be picked up by a cpan install Convert::Pluggable?

thanks for all your help, /bda

[dagolden]

I don't see that UNAUTHORIZED bit. And the module is correctly indexed:

Convert::Pluggable                0.017  E/EL/ELOHMROW/Convert-Pluggable-0.017.tar.gz

Test failures don't affect "authorization" -- that's only about whether you have permissions over the module and you do:

Convert::Pluggable,ELOHMROW,f

(Where "f" means "first-come" which means you were the first to use that package name so you claimed it.)

It might have been a transient issue with search.cpan.org.

[elohmrow]

Oh, OK, thank you for the explanation :)

sent by a bradDroid - please expect bradVity! On Mar 24, 2014 9:54 PM, "David Golden" [email protected] wrote:

I don't see that UNAUTHORIZED bit. And the module is correctly indexed:

Convert::Pluggable 0.017 E/EL/ELOHMROW/Convert-Pluggable-0.017.tar.gz

Test failures don't affect "authorization" -- that's only about whether you have permissions over the module and you do:

Convert::Pluggable,ELOHMROW,f

(Where "f" means "first-come" which means you were the first to use that package name so you claimed it.)

It might have been a transient issue with search.cpan.org.

— Reply to this email directly or view it on GitHubhttps://github.com/andk/pause/issues/108#issuecomment-38523195 .