amusecode
Bugfix issue for #850
- [x] Test issue 850
- [x] Add test to workflow for this branch
- [ ] Fix issue
- [ ] Remove workflow
- [ ] Merge & Remove branch
The test_issue_850 workflow tests issue #850 - it currently fails so the bug is still there (of course, since no fix has been made yet). I'm not sure what causes the issue, but it is clear that SeBa does not evolve star[1] from the test if a binary of stars[0,2] is added. Not sure if this extends to SeBa only evolving stars that are also in a binary (if any binary is added), perhaps also add this to the test? (cc @silviatoonen)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.
Hi all, this goes above my knowledge of amuse - if the suggestion of Inti works, let's go ahead and implement it. Otherwise, Simon would be the best person, knowing amuse & SeBa both? Cheers Silvia
Dr. Silvia Toonen Assistant professor Anton Pannekoek Institute University of Amsterdam Email: @.@.> @.@.> will soon be deactivated. Website: https://staff.fnwi.uva.nl/s.g.m.toonen/https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstaff.fnwi.uva.nl%2Fs.g.m.toonen%2F&data=04%7C01%7Cservicedesk-icts%40uva.nl%7Ce2bdbbd0a70043e9f36f08d8ccef8185%7Ca0f1cacd618c4403b94576fb3d6874e5%7C1%7C0%7C637484676327089939%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=89YxQBjtPoJ%2BC3gAfS9IC6HGNPTNQPeMg47HQL0UMoo%3D&reserved=0
From: Inti Pelupessy @.> Sent: 07 November 2022 15:47 To: amusecode/amuse @.> Cc: Silvia Toonen @.>; Mention @.> Subject: Re: [amusecode/amuse] Bugfix issue for #850 (PR #869)
— Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Famusecode%2Famuse%2Fpull%2F869%23issuecomment-1305807528&data=05%7C01%7CS.G.M.Toonen%40uva.nl%7Cc353139a950040289bb508dac0d761a4%7Ca0f1cacd618c4403b94576fb3d6874e5%7C0%7C0%7C638034328530297521%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=CJv7RiV0s7FbeYJVh6yw8ttpUWS4yMKQngCw2qLHNHI%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGUXULA6UEECKZRSM2LE54TWHEQBFANCNFSM52WFK64Q&data=05%7C01%7CS.G.M.Toonen%40uva.nl%7Cc353139a950040289bb508dac0d761a4%7Ca0f1cacd618c4403b94576fb3d6874e5%7C0%7C0%7C638034328530453743%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eZ7OQWpuWoW21lalwG35eVJ0mM8VbOsl9bIvYJwZKAA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
thanks!
Dr. Silvia Toonen Assistant professor Anton Pannekoek Institute University of Amsterdam Email: @.@.> @.@.> will soon be deactivated. Website: https://staff.fnwi.uva.nl/s.g.m.toonen/https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fstaff.fnwi.uva.nl%2Fs.g.m.toonen%2F&data=04%7C01%7Cservicedesk-icts%40uva.nl%7Ce2bdbbd0a70043e9f36f08d8ccef8185%7Ca0f1cacd618c4403b94576fb3d6874e5%7C1%7C0%7C637484676327089939%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=89YxQBjtPoJ%2BC3gAfS9IC6HGNPTNQPeMg47HQL0UMoo%3D&reserved=0
From: Steven Rieder @.> Sent: 30 November 2022 14:14 To: amusecode/amuse @.> Cc: Silvia Toonen @.>; Mention @.> Subject: Re: [amusecode/amuse] Bugfix issue for #850 (PR #869)
Test is successful, so are the regular SeBa tests. Merging.
— Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Famusecode%2Famuse%2Fpull%2F869%23issuecomment-1332212583&data=05%7C01%7CS.G.M.Toonen%40uva.nl%7C906a6fb8fb8e44d0a58308dad2dd2f72%7Ca0f1cacd618c4403b94576fb3d6874e5%7C0%7C0%7C638054144672049225%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wQMLbArFWFdZrS9mKGjf32RPU8Poz0UK3aY6Z%2BbL7Ks%3D&reserved=0, or unsubscribehttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGUXULGKF6QURRCCL2MWQ7TWK5OL7ANCNFSM52WFK64Q&data=05%7C01%7CS.G.M.Toonen%40uva.nl%7C906a6fb8fb8e44d0a58308dad2dd2f72%7Ca0f1cacd618c4403b94576fb3d6874e5%7C0%7C0%7C638054144672049225%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=rXpMdXx0S1JGDN5f6EIjhyL9yv9F%2F8CPpOuIPeehAR4%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>