deprecate / remove DOWNLOAD_CODES

[rieder]

for me its ok now, though @rieder we sort of decided to always assume DOWNLOAD_CODES=1 ??

yes - we need to implement that (by removing DOWNLOAD_CODES references?).

Originally posted by @rieder in https://github.com/amusecode/amuse/issues/805#issuecomment-985880309

[rieder]

I think we should just remove it, it has no real purpose anymore.

[rieder]

We should make sure that downloadable codes have a 'download' target in Makefile (which downloads the code), that is used only if the source directory is not yet present. We don't want the download to happen every time the code is built. Also 'distclean' should remove the source directory.

[rieder]

(this may already be the case but we should check it)

[ipelupessy]

agree

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

[ipelupessy]

todo, (1) remove DOWNLOAD_CODES (always assume ==1) and check (2) download is not done if corresponding src is available, (3) clean leaves download in placand , distclean removes it. for the following codes:

• [x] bonsai2
• [x] flash
• [x] krome
• [ ] mesa_r15140
• [ ] mesa_r2208
• [x] mocassin
• [ ] mpiamrvac
• [x] rebound
• [x] tupan
• [x] vader

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

[ipelupessy]

bonsai2 makefile looks iffy, needs testing