amuse icon indicating copy to clipboard operation
amuse copied to clipboard

Add mapper, a helper tool for making 2D maps from SPH particles.

Open rieder opened this issue 4 years ago • 14 comments

Makes life easier compared to directly using FiMap. Plan is to expand this mapper to also use it with Fresco and to add a plotting tool separately.

rieder avatar Feb 19 '21 13:02 rieder

@ipelupessy any thoughts?

rieder avatar Feb 19 '21 13:02 rieder

could be good idea... you may need to add an example for the usage (and maybe some doc string.) though..hard to see how to use it..

ipelupessy avatar Feb 19 '21 15:02 ipelupessy

~btw, I think we are using ascii encoding for the source?~ never mind its default utf-8 in python3

ipelupessy avatar Feb 19 '21 15:02 ipelupessy

could be good idea... you may need to add an example for the usage (and maybe some doc string.) though..hard to see how to use it..

yeah, use case will come in my plotting tool (see https://gist.github.com/rieder/abe1773776a9bb08503e06723d48ca66 for now). I found it better to separate these than have them in one big file.

rieder avatar Feb 19 '21 15:02 rieder

I'm still working on it, syntax will probably change as I add @property decorators and such.

rieder avatar Feb 19 '21 15:02 rieder

I simplified it and added a use case example. Still more to be done.

rieder avatar Feb 19 '21 17:02 rieder

I've added (a simplified version of) plot_hydro, which uses mapper. This seems to work well, but I'm not sure if it is "ready to merge" yet.

rieder avatar Jul 07 '21 15:07 rieder

hmm, would check your branches and remotes...

@ipelupessy I can't see anything wrong. This is part of the right PR and all.

rieder avatar Feb 08 '22 12:02 rieder

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 09 '22 13:04 stale[bot]

ready for merge?

ipelupessy avatar Apr 09 '22 14:04 ipelupessy

Almost. I’ve been using it but I need to add a nice example.

rieder avatar Apr 09 '22 15:04 rieder

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 08 '22 17:06 stale[bot]

suggest merge

ipelupessy avatar Jun 09 '22 08:06 ipelupessy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 10 '22 12:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 09 '22 12:11 stale[bot]

It's good enough, merging!

rieder avatar Mar 14 '23 16:03 rieder