remove use of numpy matrix type in generic_unit_converter
generic_unit_converter uses the numpy matrix type, which is on its way out. It is recommended to use ordinary array operations, this means:
- convert to array or remove asmatrix
- corresponding "x*y" operators (matrix multiplications) should be changed to x.dot(y)
- x**-1 to numpy.linalg.inv(x)
- and test
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.
@rieder was this fixed?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.
@rieder was this fixed? (I think it should show up on pytest)
I don’t think it was fixed.
ok just for reference: https://stackoverflow.com/questions/53254738/deprecation-status-of-the-numpy-matrix-class
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.
Are we using asmatrix anywhere?
Finally fixed