amuse icon indicating copy to clipboard operation
amuse copied to clipboard

remove use of numpy matrix type in generic_unit_converter

Open ipelupessy opened this issue 5 years ago • 7 comments

generic_unit_converter uses the numpy matrix type, which is on its way out. It is recommended to use ordinary array operations, this means:

  • convert to array or remove asmatrix
  • corresponding "x*y" operators (matrix multiplications) should be changed to x.dot(y)
  • x**-1 to numpy.linalg.inv(x)
  • and test

ipelupessy avatar Jun 05 '20 11:06 ipelupessy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 04 '22 16:03 stale[bot]

@rieder was this fixed?

ipelupessy avatar Mar 11 '22 18:03 ipelupessy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar May 10 '22 18:05 stale[bot]

@rieder was this fixed? (I think it should show up on pytest)

ipelupessy avatar May 10 '22 18:05 ipelupessy

I don’t think it was fixed.

rieder avatar May 10 '22 19:05 rieder

ok just for reference: https://stackoverflow.com/questions/53254738/deprecation-status-of-the-numpy-matrix-class

ipelupessy avatar May 10 '22 19:05 ipelupessy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 09 '22 21:07 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 06 '22 11:10 stale[bot]

Are we using asmatrix anywhere?

rieder avatar Dec 02 '22 11:12 rieder

Finally fixed

rieder avatar Jul 06 '23 15:07 rieder