Remove keyword collisions

[rieder]

Describe the bug amuse/rfi/core.py line 126 defines an "async" function. In Python 3.5+, async is a reserved keyword (https://www.python.org/dev/peps/pep-0492/). We may need to rename this function to prevent "invalid syntax" errors.

[ipelupessy]

I don't think its a big problem since the async are class methods?? (there are other collisions in the code..)

[ipelupessy]

we can maybe gather those here?

[rieder]

we can maybe gather those here?

good idea. I'll rename the issue.

[ipelupessy]

new option for async as keyword argument to function calls (#339 )

[evertrol]

FWIW: the use of async is a definite showstopper for trying to use Amuse with Python 3.7, since it's a reserved keyword as of 3.7.

[ipelupessy]

ok, asyncawait was introduced in 3.5 and 3.6 but 3.7 makes it reserved..so will change

[fjansson]

After discussing with Inti, I like the following:

• change the async function keyword to return_request
• change the .async() method to .asynchronous()
• encourage use of the function argument over the method since this allows wrapping the interface function

[rieder]

sounds good to me.

[ipelupessy]

async is fixed (4b48747)

[ipelupessy]

other cases (not specific to python 3):

• object
• format
• callable

[ipelupessy]

• set

[rieder]

#359 is a duplicate of this issue

[ipelupessy]

i think for "object" as used in the interface definitions (define_parameters, define_methods etc ) this can be replaced by "handler" (these instances of amuse.support.interface.HandleParameters etc)

[rieder]

yes, that sounds good.

[rieder]

• sum (e.g. in src/amuse/ic/kingmodel.py)

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.