amuse icon indicating copy to clipboard operation
amuse copied to clipboard

inconsistency in naming

Open silviatoonen opened this issue 11 months ago • 4 comments

Both SSE & SeBa have AMUSE function to retrieve the wind mass loss rates of the stars, however the names are different. SSE: get_mass_loss_wind SeBa: get_wind_mass_loss_rate I'd recommend we stay with the latter, as the former does not specify that it is a rate rather then an amount of mass.

silviatoonen avatar Feb 21 '25 14:02 silviatoonen

In addition:

silviatoonen avatar Feb 21 '25 14:02 silviatoonen

In addition:

Some text missing here I guess? It would be good to harmonize function/method names more, I agree.

rieder avatar Apr 24 '25 14:04 rieder

Would it be possible to adjust the interfaces to have at least one working option for each code? With the idea of the ease of switching between community codes in AMUSE, this is currently not possible if the function names change.

silviatoonen avatar Apr 24 '25 14:04 silviatoonen

I think that if a function does exactly the same, the name of that function should also be the same (facilitating switching codes). If it does something nearly the same, we should be more careful - to prevent unexpected behaviour when switching codes.

This ties in with the plan to write a whitepaper on a common API for (stellar evolution) codes.

rieder avatar Apr 24 '25 14:04 rieder